From: Aaron Schulz <aschulz@wikimedia.org>
Date: Wed, 26 Sep 2012 20:40:18 +0000 (-0700)
Subject: Removed READ_LATEST default from Revision::newFromPageId().
X-Git-Tag: 1.31.0-rc.0~22089^2
X-Git-Url: http://git.cyclocoop.org/%22.%24info%5B?a=commitdiff_plain;h=402da95a4b59c2d2fa20692e2a8df17ee6a83432;p=lhc%2Fweb%2Fwiklou.git

Removed READ_LATEST default from Revision::newFromPageId().

Change-Id: If3feb424314be5db88cb0f25c0358b3be4cad572
---

diff --git a/includes/Revision.php b/includes/Revision.php
index 20cc8f5862..55f6407c3a 100644
--- a/includes/Revision.php
+++ b/includes/Revision.php
@@ -114,15 +114,13 @@ class Revision implements IDBAccessObject {
 	 * @param $flags Integer Bitfield (optional)
 	 * @return Revision or null
 	 */
-	public static function newFromPageId( $pageId, $revId = 0, $flags = null ) {
+	public static function newFromPageId( $pageId, $revId = 0, $flags = 0 ) {
 		$conds = array( 'page_id' => $pageId );
 		if ( $revId ) {
 			$conds['rev_id'] = $revId;
 		} else {
 			// Use a join to get the latest revision
 			$conds[] = 'rev_id = page_latest';
-			// Callers assume this will be up-to-date
-			$flags = is_int( $flags ) ? $flags : self::READ_LATEST; // b/c
 		}
 		return self::newFromConds( $conds, (int)$flags );
 	}